Erik Huelsmann (@ehuelsmann) on GitLab, 2018-10-14.
@mmontone, @tplotnikov, @vdardel: this branch adds markdown processing but generates a horrible TOC (and doesn't recognize the "Awesome" image/link).
The "Awesome" image/link might be a further improvement, but if we can convince this branch to create an acceptable ToC, I'd think we're a long way towards migrating a few important pages to Markdown.
The pages which I'd like to be Markdown most of all are the news page (which it already is) and the "project-intro" page, simply because I have to rewrite it completely. Which also explains why I'd like to have the ToC (project-intro uses that) but not so much about the "Awesome" image/link (project-intro doesn't use it; neither does news).
Closes #9.
0 commits, 0 files changed
Dave Cooper (@dcooper) on GitLab, 2018-10-15.
@ehuelsmann: Just curious - why are you changing back to :cl-markdown again?
Dave Cooper (@dcooper) on GitLab, 2018-10-15.
I guess you changed because :cl-markdown purports to handle tables of contents?
By the way, another approach to all this (after merging !53) could be to pre-pre-process any .md files into .lisp files, just writing the whole contents as a big string wrapped in that wmd macro (expanding said macro as needed) - then let the preprocess-lisp-files deal with it. That way we’d be running all markdown processing through one central (standardised) chokepoint. (admittedly though, you’d have to do something a little extra to deal with the headers - parsing them and writing out as a :headers-plist in the .lisp, only to have them get converted back to yaml style in the .html)
As far as the news.md - if you set that up as a .lisp file from the beginning instead of raw .md, you could use lhtml to insert the extra bits of HTML it needs, rather than inserting those hard-codedly in the processing function. That way the only special processing for news.html would be the generating of the newsbox.
Erik Huelsmann (@ehuelsmann) on GitLab, 2018-10-15.
The reason to change it back to cl-markdown is indeed the fact that it supposedly handles the ToC. This MR has been marked WIP, which means it can't be merged yet. The intent for that is to show what I'm currently working on, hopefully opening up some discussion and/or cooperation by bringing my work forward.
Erik Huelsmann (@ehuelsmann) on GitLab, 2018-10-20.
@mmontone, @vdardel, @tplotnikov: please review this branch which adds Markdown processing and is supposed to close #9 and let me know what you think!
Mariano Montone (@mmontone) on GitLab, 2018-10-20.
Looks good enough to me. I can adjust a couple of things with the TOC later perhaps. And I would add a title to libraries page.
Erik Huelsmann (@ehuelsmann) on GitLab, 2018-10-20.
Title comment incorporated.
We probably want more improvements on the current version indeed, however I think it's a very nice next step (without any real regressions, which is an important point IMO). I'll merge to master after more review or some time tomorrow if no further comments come up.
Tim Plotnikov (@tplotnikov) on GitLab, 2018-10-21.
I think thats fine.
Sign in to comment.