⚒Anvil
Sign in

clo / cl-site public

merged

Added current AllegroServe and replaced Python test server with it. 56

opened by common-lisp.net
Ccommon-lisp.net wrote

Dave Cooper (@dcooper) on GitLab, 2018-10-17.

Added a temporary snapshot of current AllegroServe into cl-site repository (we'll have to carry it here until it manages to get into Quicklisp -- I'm working on that). Changed default make serve command to publish & serve from CL/aserve instead of Python. By default, loading build.lisp will now start serving the cl-site on localhost:8008.

Keeping the python server around for now for compatibility testing, benchmarking, etc.

0 commits, 0 files changed

common-lisp.net added 2 commits <ul><li>9f396c5e - Got rid of the local aserve and replaced with dependency on</li><li>5b4857b9 - Merge branch &#39;zacl+aserve&#39; into &#39;master&#39;</li></ul> [Compare with previous version](https://gitlab.common-lisp.net/clo/cl-site/merge_requests/56/diffs?diff_id=805&start_sha=0c8884f68f7590834bcc7fbdaa1f572d0f5e98a8)
common-lisp.net added 2 commits <ul><li>9d7f840f - Attempting to update Quicklisp dist</li><li>e11ffc5a - Merge branch &#39;zacl+aserve&#39; into &#39;master&#39;</li></ul> [Compare with previous version](https://gitlab.common-lisp.net/clo/cl-site/merge_requests/56/diffs?diff_id=807&start_sha=5b4857b959dc437f624cac25f5e8d1c7bebddcfb)
common-lisp.net added 2 commits <ul><li>988aa7c6 - temporarily changed build.lisp to just update quicklisp.</li><li>43537df4 - Merge branch &#39;zacl+aserve&#39; into &#39;master&#39;</li></ul> [Compare with previous version](https://gitlab.common-lisp.net/clo/cl-site/merge_requests/56/diffs?diff_id=809&start_sha=e11ffc5ad0e2f6b5c5df27e093e1cac90d8a3308)
common-lisp.net added 2 commits <ul><li>a554176c - put back full build after apparently having updated Quicklisp dist.</li><li>353da115 - Merge branch &#39;zacl+aserve&#39; into &#39;master&#39;</li></ul> [Compare with previous version](https://gitlab.common-lisp.net/clo/cl-site/merge_requests/56/diffs?diff_id=811&start_sha=43537df475d9d9a51eb093a54fa5cbb455d005a7)
Ccommon-lisp.net

Administrator (@root) on GitLab, 2018-10-19.

This turns build into serve. Why do we need that? Can't we keep build and serve separate?

I mean, the pipeline wants to build, not serve. And even if we want to serve from lisp, we don't want to do that in the pipeline: we'd want to do that after a deploy.

Ccommon-lisp.net

Administrator (@root) on GitLab, 2018-10-19.

You just moved the simplest of instructions down to the end. Don't we want the barrier of entry as low as possible? Who's going to read beyond the complex instructions to find the simple ones?

common-lisp.net marked as a **Work In Progress**
common-lisp.net changed the description
Ccommon-lisp.net

Dave Cooper (@dcooper) on GitLab, 2018-10-19.

This can be considered a test serve. I think it's reasonable that part of the pipeline should be to confirm that the test server fires up without incident.

Note that the (cl-site:start-aserve) should be tolerant of the default port already being busy (it then tries subsequent ports).

The command-line make (used by the pipeline, right?) will start serving, then Lisp will immediately exit, so it's not doing more than testing that the server can start up.

common-lisp.net added 2 commits <ul><li>ebca2bd3 - added .fasl</li><li>c4c6a8c4 - Merge branch &#39;master&#39; of common-lisp.net:dcooper/cl-site</li></ul> [Compare with previous version](https://gitlab.common-lisp.net/clo/cl-site/merge_requests/56/diffs?diff_id=813&start_sha=353da115873b740172b08065281a1f052c3d1484)
common-lisp.net changed this line in version 6 of the diff
common-lisp.net changed this line in version 6 of the diff
Ccommon-lisp.net

Dave Cooper (@dcooper) on GitLab, 2018-10-19.

Just reverted this. But I'm still not "recommending" command-line over running a Lisp repl (let the user make that judgement).

common-lisp.net resolved all discussions
common-lisp.net unmarked as a **Work In Progress**
common-lisp.net added 10 commits <ul><li>c4c6a8c4...8418c171 - 8 commits from branch <code>clo:master</code></li><li>c6ba3f05 - Merge branch &#39;zacl+aserve&#39;</li><li>f6c8b17f - added .fasl</li></ul> [Compare with previous version](https://gitlab.common-lisp.net/clo/cl-site/merge_requests/56/diffs?diff_id=822&start_sha=c4c6a8c4cbe6cb3f8d3736e667176c20e40c57b9)
Ccommon-lisp.net

Dave Cooper (@dcooper) on GitLab, 2018-10-19.

I hope you don't mind - maybe I shouldn't have, but I went ahead and deleted all the long comments because I think anyone reading them in the future would get a headache and they wouldn't serve any good purpose. Sorry for having been so wordy.

Anyway, I've resolved the WIP status and took the test serving out of the pipeline. README.md is updated accordingly to let folks know how to run the test server.

Hoping this can be merged now, and we'll hold off on SBCL upgrade for another day (or just keep going with the stock one, as you mentioned)...

common-lisp.net added 1 commit <ul><li>c748b33d - Updated README to get rid of reference to now-deleted python server.</li></ul> [Compare with previous version](https://gitlab.common-lisp.net/clo/cl-site/merge_requests/56/diffs?diff_id=823&start_sha=f6c8b17fefe7452eb510991e6ed088944ff8e0a7)
common-lisp.net merged
common-lisp.net mentioned in commit 20326654358e65aa31939a3d9387be70fbb0bd1d
Ccommon-lisp.net

Erik Huelsmann (@ehuelsmann) on GitLab, 2018-10-20.

Thanks!

For the next steps, though lets focus on getting the functionality we actually need to update the site's content into the site builder (one way or another).

Sign in to comment.