⚒Anvil
Sign in

clo / cl-site public

merged

Add a FAQ item describing how to deploy project pages 77

opened by common-lisp.net
Ccommon-lisp.net wrote

Erik Huelsmann (@ehuelsmann) on GitLab, 2018-11-04.

0 commits, 0 files changed

Ccommon-lisp.net

Erik Huelsmann (@ehuelsmann) on GitLab, 2018-11-04.

@mmontone, @tplotnikov, @vdardel, @pmarek please review the text added by this commit to see if it's clear how to use GitLab Pages deployment on our site. Follow-up MRs with pictures to show the steps would also be highly appreciated.

Ccommon-lisp.net

Philipp Marek (@pmarek) on GitLab, 2018-11-05.

"from" the master branch only?

Ccommon-lisp.net

Vincent Dardel (@vdardel) on GitLab, 2018-11-05.

I believe the "tags" is optional and in fact it isn't explained below.

Ccommon-lisp.net

Vincent Dardel (@vdardel) on GitLab, 2018-11-05.

tip on the linter ? To be found on CI/CD -> pipelines -> CI lint button (https://gitlab.com/ci/lint)

Ccommon-lisp.net

Vincent Dardel (@vdardel) on GitLab, 2018-11-05.

and the doc: https://docs.gitlab.com/ee/user/project/pages/

common-lisp.net changed this line in [version 2 of the diff](https://gitlab.common-lisp.net/clo/cl-site/merge_requests/77/diffs?diff_id=883&start_sha=38b0193346da0af2a88110b85f65e5f6e45b1f61#4c68dd9ed7c5091c294dc266e86aaca19b6f591c_70_70)
common-lisp.net changed this line in [version 2 of the diff](https://gitlab.common-lisp.net/clo/cl-site/merge_requests/77/diffs?diff_id=883&start_sha=38b0193346da0af2a88110b85f65e5f6e45b1f61#4c68dd9ed7c5091c294dc266e86aaca19b6f591c_101_115)
common-lisp.net added 1 commit <ul><li>122353ed - Incorporate review comments</li></ul> [Compare with previous version](https://gitlab.common-lisp.net/clo/cl-site/merge_requests/77/diffs?diff_id=883&start_sha=38b0193346da0af2a88110b85f65e5f6e45b1f61)
Ccommon-lisp.net

Erik Huelsmann (@ehuelsmann) on GitLab, 2018-11-05.

Thanks for the review! I've addressed your point in my latest commit.

Ccommon-lisp.net

Erik Huelsmann (@ehuelsmann) on GitLab, 2018-11-05.

Thanks for the review! I've addressed your point in my latest commit.

Ccommon-lisp.net

Erik Huelsmann (@ehuelsmann) on GitLab, 2018-11-05.

Thanks for the review! I've included a reference to the linter in my latest commit.

Ccommon-lisp.net

Erik Huelsmann (@ehuelsmann) on GitLab, 2018-11-05.

Thanks for the review! I've added your suggestion in my latest commit.

common-lisp.net resolved all discussions
Ccommon-lisp.net

Vincent Dardel (@vdardel) on GitLab, 2018-11-06.

+1 nice doc.

common-lisp.net merged
common-lisp.net mentioned in commit 33ef11525bc6cdc7da4cc5068fa87954b6af951e

Sign in to comment.